Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix label selector when required #23186

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

bramkragten
Copy link
Member

Proposed change

Required was not passed to the picker, and it was not present in initial data.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten added this to the 2024.12 milestone Dec 6, 2024
@MindFreeze MindFreeze enabled auto-merge (squash) December 6, 2024 15:12
@MindFreeze MindFreeze merged commit 0b7af71 into dev Dec 6, 2024
12 checks passed
@MindFreeze MindFreeze deleted the fix-label-selector-required branch December 6, 2024 15:14
bramkragten added a commit that referenced this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants